Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias #eql? to #== and define #hash on Protobuf::Message #398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Alias #eql? to #== and define #hash on Protobuf::Message #398

wants to merge 1 commit into from

Conversation

drcapulet
Copy link
Contributor

Hashes (and some methods of Array) use the #eql? and #hash methods, this defines them so that those operations work correctly.

@film42
Copy link
Member

film42 commented Aug 28, 2019

Looks good. Needs a rubocop fix but otherwise 👍 .

@drcapulet
Copy link
Contributor Author

Ping @film42, anything else needed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drcapulet @film42